Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1432: add details around expectations.withArgs behavior to docs #1501

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

dcolucci
Copy link
Contributor

Purpose

Fix issue #1432 - adds details to documentation of expectations methods withArgs and withExactArgs to prevent confusion, such as #992

How to verify

Probably not necessary to run the docs application - please review the copy and confirm whether it is clear, informative, etc, and whether I've touched the correct / necessary files.

@coveralls
Copy link

coveralls commented Jul 28, 2017

Coverage Status

Coverage remained the same at 95.517% when pulling e7890a5 on dcolucci:issues/#1432 into cbf1128 on sinonjs:master.

Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a bit too much :-) Basically, don't touch anything in _releases - change the source for upcoming releases

@dcolucci
Copy link
Contributor Author

Thanks @fatso83, my mistake - updated

@coveralls
Copy link

coveralls commented Jul 28, 2017

Coverage Status

Coverage remained the same at 95.522% when pulling 8f7bd5d on dcolucci:issues/#1432 into 0d099aa on sinonjs:master.

Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Always wondered about this myself, actually, but I always stick to simple tests so never needed to find out.

@fatso83 fatso83 merged commit 6c1aa55 into sinonjs:master Jul 28, 2017
@mroderick
Copy link
Member

Thank you!

franck-romano pushed a commit to franck-romano/sinon that referenced this pull request Oct 1, 2019
rkaw92 added a commit to rkaw92/warsawjs-workshop-50-unit-testing that referenced this pull request Nov 16, 2020
This changes how the tests work as an example of behavior verification,
as opposed to state verification. The third test is still not ported,
see: sinonjs/sinon#1501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants