Update docs for sandbox config #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointed to a subdirectory
|
Hmmm, this pull request reverted my changes from #1515. Was that on purpose? |
|
Damn! No, that was NOT intentional. Not sure how that happened. |
|
Fixed by 2a04615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR)
The migration docs for 3.0 mentions that the format for the config object to
sinon.useFakeTimers()has changed, but this is also used by the sandboxes. This PR updates the migration docs with a new section, updates the sandbox docs with the omission, and also fixes a couple of relative links that pointed to 404s.I needed to change both the source and the released docs, as it can be regarded as a bug that this fix is not already present.
How to verify - mandatory
docs/CONTRIBUTING.MD.