Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install aws by default #1055

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Install aws by default #1055

merged 1 commit into from
Aug 9, 2022

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Aug 9, 2022

Based on the offline discussion, we found it makes sense to install AWS CLI by default when installing skypilot:

  1. The AWS most commonly used by our users.
  2. It makes no sense to install a no-cloud version of skypilot with pip install skypilot
  3. The installation of AWS CLI is pretty quick.

This also fixes the hint in the document for installing grpc for Apple Silicon.

I will cherry-pick this PR into the releases/0.1.1.

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Thanks for the quick fix!

@Michaelvll Michaelvll merged commit 8059a2b into master Aug 9, 2022
@Michaelvll Michaelvll deleted the fix-installation branch August 9, 2022 22:05
Michaelvll added a commit that referenced this pull request Aug 9, 2022
Michaelvll added a commit that referenced this pull request Aug 9, 2022
* Install aws by default (#1055)

* Fix github action for PR on releases branches (#1058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants