Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spot] Distinguish spot controller names for different users (!! backward incompatible for spot controller !!) #1101

Merged
merged 2 commits into from
Aug 19, 2022
Merged

[Spot] Distinguish spot controller names for different users (!! backward incompatible for spot controller !!) #1101

merged 2 commits into from
Aug 19, 2022

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Aug 19, 2022 •
edited
Loading

Closes #1100.

Warning: This will be not backward compatible. Please sky down -p sky-spot-controller first before updating to this commit to avoid leakage of the old sky-spot-controller.

Tested:

  • spot related tests in smoke test

@Michaelvll Michaelvll changed the title Distinguish spot controller names for different users [Spot] Distinguish spot controller names for different users Aug 19, 2022
concretevitamin
concretevitamin approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we also update the PR title with (backward incompatible for spot controller)? Helps users spot this easier, such as in release logs.

sky/spot/spot_utils.py Show resolved Hide resolved
sky/usage/usage_lib.py Outdated Show resolved Hide resolved
sky/utils/common_utils.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll changed the title [Spot] Distinguish spot controller names for different users [Spot] Distinguish spot controller names for different users (backward incompatible for spot controller) Aug 19, 2022
@Michaelvll Michaelvll changed the title [Spot] Distinguish spot controller names for different users (backward incompatible for spot controller) [Spot] Distinguish spot controller names for different users (!! backward incompatible for spot controller !!) Aug 19, 2022
@Michaelvll Michaelvll merged commit 18ab2df into master Aug 19, 2022
@Michaelvll Michaelvll deleted the distinguish-spot-controller branch August 19, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Spot] Users in the same GCP project will have conflict on spot controller
2 participants
@Michaelvll @concretevitamin