Fixes ray dashboard hanging problem (#1088) #1109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1088.
This fixes the ray dashboard hanging problem. By checking the
py-spy dump --locals --pid <dashboard.py pid>
, we found that the dashboard has some leaked thread_monitor_job
in thedashboard/modules/job/job_manager.py
. The problem is caused byawait job_supervisor.ping.remote()
, which may not normally raise the exception after the actorjob_supervisor
is exited.After switching the
await
toray.get
, it seems the problem is solved.Tested: