Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for cloud import errors #1156

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Improve error messages for cloud import errors #1156

merged 2 commits into from
Sep 6, 2022

Conversation

sumanthgenz
Copy link
Collaborator

Changes:

  • Made message more actionable/descriptive
  • (e.g. Fail to import dependencies for Azure. See README for how to install it -> Fail to import dependencies for Azure. Try pip install "skypilot[azure]")

concretevitamin
concretevitamin approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sumanthgenz.

@concretevitamin concretevitamin merged commit 0a9e562 into skypilot-org:master Sep 6, 2022
@sumanthgenz sumanthgenz deleted the sgurram_improve_import_error_messages branch September 6, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumanthgenz @concretevitamin