Relative cluster yaml #1176
Merged
Relative cluster yaml #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romilbhardwaj
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
lgtm, thanks for fixing! :)
If you haven't already, can you also verify if this enables the container use case as mentioned in this comment?
| @@ -13,13 +13,23 @@ | |||
|
|
|||
| from sky import sky_logging | |||
|
|
|||
| _USER_HASH_FILE = os.path.expanduser('~/.sky/user_hash') | |||
There was a problem hiding this comment.
I think this is a good change - in the future this also allows us to move the user to a new machine while preserving their hash
Michaelvll
commented
Sep 29, 2022
There was a problem hiding this comment.
Thank you for the review @romilbhardwaj! Just tested it with the docker case:
sudo docker run -it --rm -v $HOME/.sky:/root/.sky:rw -v $HOME/.config:/root/.config:rw -v $HOME/.aws:/root/.aws:ro continuumio/miniconda /bin/bashsky cpunode -c docker-test --cloud gcpin the dockersky down docker-teston the host machine.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1138.
Since this is also requested by @lhqing to share the
~/.skyfolder across different devices, we may want to have this PR to unblock the issue. This PR replaces the path for the cluster yaml to the relative path as suggested by @concretevitamin in #1138 (comment)Tested:
sky start existing-cluster;sky stop existing-cluster;sky down existing-clustersky launch --cloud gcp '';sky launch -c test-zhwu --cloud gcp '';scp ~/.sky test-zhwu:~/.sky;ssh test-zhwu;sky down sky-ea57-zhwu -y;sky status