Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Credentials Check #1194

Merged
merged 5 commits into from
Oct 5, 2022
Merged

AWS Credentials Check #1194

merged 5 commits into from
Oct 5, 2022

Conversation

michaelzhiluo
Copy link
Collaborator

Fixes #1177. Checks if the AWS credentials are valid and can connect to AWS services.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @michaelzhiluo!

sky/clouds/aws.py Outdated Show resolved Hide resolved
@michaelzhiluo
Copy link
Collaborator Author

@Michaelvll PTAL, updated with your comments

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @michaelzhiluo ! Just tested it locally, and it worked very well. LGTM.

sky/clouds/aws.py Outdated Show resolved Hide resolved
@michaelzhiluo michaelzhiluo merged commit 05d4218 into master Oct 5, 2022
@Michaelvll Michaelvll deleted the aws_credentials_check branch October 6, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify aws credentials when sky check
2 participants