Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for spot TPU pod recovery #1470

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Hotfix for spot TPU pod recovery #1470

merged 2 commits into from
Nov 30, 2022

Conversation

infwinston
Copy link
Member

@infwinston infwinston commented Nov 30, 2022 •
edited
Loading

A hotfix to temporarily close #1468. We may need to modify the controller logic to make it more future proof.

The issue is: When preemption happens, our spot controller won't cleanup preempted VMs before running another sky launch. This causes two VMs to co-exist and both the preempted one and the recovered one will be returned.

concretevitamin
concretevitamin reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue? Probably @Michaelvll knows more context.

sky/backends/cloud_vm_ray_backend.py
@@ -2623,7 +2623,8 @@ def teardown_no_lock(self,

query_cmd = (
f'gcloud compute tpus tpu-vm list --filter='
f'\\(labels.ray-cluster-name={cluster_name}\\) '
f'"(labels.ray-cluster-name={cluster_name} AND '
f'state!=PREEMPTED)" '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to preempted TPUs? Is it true that they require no further cleanup actions -- i.e., gcloud compute tpus tpu-vm delete -- from us (e.g., disks)? Worth a comment!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point I just updated some comments.

According to reference, TPU VM's disk is not persistent unless manually specifying it.
So a preempted TPU VM will cost zero and should be safe to ignore for cost perspective. (IIRC, GCP will clean them up after a while)

However, I agree we should try to cleanup the preempted VMs if possible, which requires changing the logic in spot controller to be tearing down VM first and then sky launch again.

For now I just wanted to ship to wilson asap. I'll create another PR to fix this.

Michaelvll
Michaelvll reviewed Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @infwinston!

sky/backends/backend_utils.py
Comment on lines +1224 to 1226
f'"(labels.ray-cluster-name={cluster_name} AND '
f'state!=PREEMPTED)" '
f'--zone={zone} --format=value\\(name\\)')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

A minor thing that may not be good to fix in this PR is that in L1150, we directly return the IPs, without checking whether the number of nodes in the cluster matches the expected nodes as we done in L1209. Can we raise the exceptions.FetchIPError(.FetchIPError.Reason.HEAD) instead of handling it separately below?

skypilot/sky/backends/backend_utils.py

Lines 1620 to 1622 in 2abcde3

if len(ips) == 0:
raise exceptions.FetchIPError(
reason=exceptions.FetchIPError.Reason.HEAD)

Also, get_node_ips also checks the ray cluster is correctly running on the cluster. Is it possible for TPU VM having multiple nodes? If yes, we may want to check the healthiness of the ray cluster as well.

Copy link
Member Author

@infwinston infwinston Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, we should make the behavior consistent and a part of the issue is related to #1185.
I'll make sure that PR fixes this and merge it asap.

@infwinston
Copy link
Member Author

infwinston commented Nov 30, 2022 •
edited
Loading

What's the issue? Probably @Michaelvll knows more context.

Ah sorry the issue is: When preemption happens, our spot controller won't cleanup preempted VMs before running another sky launch. This causes two VMs to co-exist and both the preempted one and the recovered one will be returned during the gcloud query which triggered the bug.

Michaelvll
Michaelvll approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may want to test the autostop and sky status -r for the TPU VM before merging it. :)

@infwinston
Copy link
Member Author

Just tested sky status -r works. Offline discussion with @Michaelvll: we should block sky autostop spot VMs given that sky stop a spot VM is not supported.

@infwinston
Copy link
Member Author

Merging this for now to unblock our user. Also will work on a long-term fix which requires changing some node provider logic.

@infwinston infwinston mentioned this pull request Nov 30, 2022
Closed
@infwinston infwinston merged commit b07a909 into master Nov 30, 2022
@infwinston infwinston deleted the spot-tpu-bug branch November 30, 2022 05:59
concretevitamin pushed a commit that referenced this pull request Dec 1, 2022
@infwinston @concretevitamin
Hotfix for spot TPU pod recovery (#1470)
b6cd0d0 
* hotfix

* comment
sumanthgenz pushed a commit to sumanthgenz/skypilot that referenced this pull request Jan 15, 2023
@infwinston
Hotfix for spot TPU pod recovery (skypilot-org#1470)
0563248 
* hotfix

* comment
Michaelvll added a commit that referenced this pull request Jan 18, 2023
@sumanthgenz @Michaelvll
@concretevitamin @infwinston @romilbhardwaj @michaelzhiluo @iojw @ewzeng @WoosukKwon @dongreenberg
[Cost tracking] Cost tracking (sky cost-report) for clusters (#1301)
983f5fa 
* add cost tracking for clusters that handles launching, re-starting, getting status, stopping and downing clusters, but no auto-stopping

* address Romil PR comments

* address Zhanghao PR comments

* fix nit

* address more PR comments

* address last wave of PR comments

* sky

* address fixing argument for requested resources and fixing spot tests for CI

* address more PR comments

* make tests resources a list to prevent errors

* fix tests again

* address PR comments, including adding fetchall to fix status one cluster only bug

* fix PR comments

* change progress bar interference on stop/down

* add sky report instead of showing cost on other commands

* address cost report PR comments

* address more PR comments on sky report

* [Core] Port ray 2.0.1 (#1133)

* update ray node provider to 2.0.0

update patches

Adapt to ray functions in 2.0.0

update azure-cli version for faster installation

format

[Onprem] Automatically install sky dependencies (#1116)

* Remove root user, move ray cluster to admin

* Automatically install sky dependencies

* Fix admin alignment

* Fix PR

* Address romil's comments

* F

* Addressed Romil's comments

Add `--retry-until-up`, `--region`, `--zone`, and `--idle-minutes-to-autostop` for interactive nodes (#1207)

* Add --retry-until-up flag for interactive nodes

* Add --region flag for interactive nodes

* Add --idle-minutes-to-autostop flag for interactive nodes

* Add --zone flag for interactive nodes

* Update help messages

* Address nit

Add all region option in catalog fetcher and speed up azure fetcher (#1204)

* Port changes

* format

* add t2a exclusion back

* fix A100 for GCP

* fix aws fetching for p4de.24xlarge

* Fill GPUInfo

* fix

* address part of comments

* address comments

* add test for A100

* patch GpuInfo

* Add generation info

* Add capabilities back to azure and fix aws

* fix azure catalog

* format

* lint

* remove zone from azure

* fix azure

* Add analyze for csv

* update catalog analysis

* format

* backward compatible for azure_catalog

* yapf

* fix GCP catalog

* fix A100-80GB

* format

* increase version number

* only keep useful columns for aws

* remove capabilities from azure

* add az to AWS

Revert "Add `--retry-until-up`, `--region`, `--zone`, and `--idle-minutes-to-autostop` for interactive nodes" (#1220)

Revert "Add `--retry-until-up`, `--region`, `--zone`, and `--idle-minutes-to-autostop` for interactive nodes (#1207)"

This reverts commit f06416d.

[Storage] Add `StorageMode` to __init__ (#1223)

* Add storage mode to __init__

* fix

[Example] Minimal containerized app example (#1212)

* Container example

* parenthesis

* Add explicit StorageMode

* lint

Fix Mac Version in Setup.py (#1224)

Fix mac

Reduce iops for aws instances (#1221)

* set the default iops to be same as console for AWS

* fix

Revert "Reduce iops for aws instances" (#1229)

Revert "Reduce iops for aws instances (#1221)"

This reverts commit 29f1458.

update back compat test

* parent 06afd93
author Zhanghao Wu <zhanghao.wu@outlook.com> 1665364265 -0700
committer Zhanghao Wu <zhanghao.wu@outlook.com> 1665899898 -0700

parent 06afd93
author Zhanghao Wu <zhanghao.wu@outlook.com> 1665364265 -0700
committer Zhanghao Wu <zhanghao.wu@outlook.com> 1665899681 -0700

Support for autodown

Change API to terminate

fix flag

address comment

format

Rename terminate to down

add smoke test

format

fix syntax

use gcp for autodown test

fix smoke test

fix smoke test

address comments

Switch back to terminate

Change back to tear down

Change to tear down

fix comment

* Fix rebase issue

* address comments

* address

* fix setup.py

* upgrade to 2.0.1

* Fix docs for ray version

* Fix example

* fix backward compatibility test

* Fix onprem job submission

* add steps for backward compat test

* docs: Remove version from docs html titles. (#1303)

Remove version from docs html titles.

* Fix unnecessary ssh hanging issue on Ray (#851)

* Fix ray hanging ssh issue

* Fix

* change the order back

* Update node status after first attempt

* Set `--rename-dir-limit` for gcsfuse to allow dir renames (#1296)

Set rename_dir_lim for gcsfuse

* Docs: polish `sky.Task` doc strings. (#1302)

* WIP

* Polish sky.Task doc strings.

* docs: expose Task (a subset of methods); hide Dag.

* Tweak Task method order; in docs display methods by source order.

* CLI docs: tweak order; tweak `spot launch`.

* Address comments.

* Code block formatting.

* [Launch/Backward Compatibility] Fix incorrect Ray YAML issue (#1287)

* Fix incorrect Ray YAML issue

* yapf

* fix

* comments

* [Storage] add `--implicit-dirs` for gcsfuse (#1312)

add --implicit-dirs

* Improving README. (#1308)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Port landing paras to docs index.rst.

* [UX] Disable python output buffer by default (#1290)

diable python output buffer

* [Storage][Filemounts] Set relative dir root to workdir (#1315)

Set relative dir root to workdir for file_mounts

* Fix Sky Storage Delete more than 256 Items/folders + Bulk Deletion Tests (#1285)

* fix

* Add romil's suggestions

* Add bulk deletion tests

* ok

* Fix

* [Storage] Add lazy unmount flag (#1320)

Add lazy unmount flag

* [Core] Fix skylet checking (#1325)

* Fix skylet checking

* exclude grep

* [UX] remove stacktrace for pipe and ssh info (#1324)

* UX: remove stacktrace for pipe and ssh info

* Add comment

* Avoid ray output in the logs

* format

* revert ssh quiet option

* [Dependency] Fix colorama dependency issue with awscli (#1323)

* Fix colorama dependency issue with awscli

* fix ux for storage delete

* Add roadmap. (#1317)

* Add roadmap.

* Update ROADMAP.md

* Fix SKY_NODE_RANK environment variable (#1291)

* Add flag for retrieving internal node ips

* Ensure SKY_NODE_RANK is 0 for head and stable

* Clearer comment for get_internal_ips

* Handle different num nodes correctly

* Address PR comments

* Address nits

* [Spot] Fix race condition for spot logs (#1329)

* Fix race condition for spot logs

* fix

* fix comment

* address comments

* add comment

* Add TPU Pod to doc (#1318)

* add pod to doc

* Apply suggestions from code review

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* comments

* comments

* update bucket note

* Apply suggestions from code review

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* update

* update

* fix

* fix

* comments

* fix

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* [UX] Add environment variable `SKY_NUM_GPUS_PER_NODE` (#1337)

* add SKY_NUM_GPUS_PER_NODE

* increase multi-node progress timeout

* pin torch version

* add comment

* address comment

* fix smoke test

* address comments

* [Image] Fix blocking by unattended-upgrade (#1347)

* Fix blocking by unattended-upgrade

* adopt to gcp and azure

* [Test/Azure] Fix the torch version in examples for smoke test and change the credential for Azure  (#1330)

* Upgrade images for three clouds

* Fix cuda version

* pin cuda version for torch

* Fix torch version

* fix comments

* Fix azure provider

* fix credential

* revert back to previous azure image

* switch back to cuda 11.3 for pytorch due to azure's image

* fix torch installation

* increase the multi-node timeout

* Update sky/clouds/azure.py

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* revert aws image version

* pin cu113 for huggingface

* Add comment

* format

* Update sky/clouds/aws.py

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* Update sky/clouds/gcp.py

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* revert gcp image

* Fix doc

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* [Docs] Reorganizing docs. (#1316)

* Reorganizing docs.

* V2.

* Reorg + rewording

* Address comments

* Remove 'convenient'

* Update `SKY_NODE_RANK` docs (#1350)

* Add tip for node rank to docs

* Update formatting

* Indent fix.

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* Add `--retry-until-up`, `--region`, `--zone`, and `--idle-minutes-to-autostop` for interactive nodes (v2) (#1297)

* Add --region, --zone, --idle-minutes-to-autostop, and --retry-until-up for
interactive nodes

* Update user_requested_resources

* Add --down for interactive nodes and refactor auto{stop,down} edge case

* Refactor click options

* Revert "Refactor click options"

This reverts commit 10a06a9.

* Fix TPU Pod (#1358)

* fix pod

* yapf

* Minor fix for yapf warnings (#1362)

* [Docs] Clarify Storage mounting details (#1365)

* fix incorrect statements

* fix incorrect statements

* fix incorrect statements

* Fix bugs in GCP A100 prices (#1368)

* Fix GCP A100 price bugs

* yapf

* [Custom Image] Support tag for the images and global regions (#1366)

* Support image tag for AWS

* add gcp image support

* address comments

* fix

* remove pandas warning

* Add example for using ubuntu1804

* add ubuntu 1804 in the test

* Enforce trying us regions first

* format

* address comments

* address comments

* Add docs and rename methods

* Add fetch global regions for GCP

* Add all regions for Azure

* rename and add doc

* remvoe accidently added folder

* fix service_catalog

* remove extra line

* Address comments

* mkdir for catalog path

* increase waiting time in test

* fix test recovery

* format

* [UX/Doc] Add disk size in resource display and a minor fix for the doc (#1371)

Minor fix for docs and ux

* [Onprem] Support for Different Type of GPUs + Small Bugfix (#1356)

* Ok

* Great suggestion from Zhanghao

* fix

* Update tutorial.rst

* Pin `torch` in various examples to avoid cuda version issues. (#1378)

* tutorial.rst: pin `torch` to avoid version issues.

Tested:
- Ran on both AWS and GCP.

* Fixes two more yamls

* [Env] SKYPILOT_JOB_ID for all tasks (#1377)

* Add run id for normal job

* add example for the run id

* fix env_check

* fix env_check

* fix

* address comments

* Rename to SKYPILOT_JOB_ID

* rename the controller's job id to avoid confusion

* rename env variables

* fix

* [Core] Add support for detach setup (#1379)

* Add support for async setup

* Fix logging

* Add test for async setup

* add parens

* fix

* refactor a bit

* Fix status

* fix smoke test

* rename

* fix is_cluster_idle function

* format

* address comments

* fix

* Add setup failed

* Fix failed setup

* Add comment

* Add comments

* format

* fix logs

* format

* address comments

* Minor UX fix: `sky cancel` should not print stacktraces. (#1385)

* Minor UX fix: `sky cancel` should not print stacktraces.

* Wording fix.

* exit 1

* [UX] Disable ssh connection sharing for setup (#1390)

* Disable ssh connection sharing for setup

* format

* remove redundant

* fix type hint

* Docs: multi-node clarifications, and ssh into workers. (#1363)

* Fixes #1338: add docs on logging into workers.

* Fixes #1340 and fixes #1339.

* Address comments

* Reword.

* Hint.

* Fix Logging for `sky launch` on new machine (#1382)

* ok

* ok

* Ok

* ok

* Unify methods

* ok

* fix

* [Image] Support passing AMIs for different regions (#1384)

* image dict in resources

* fix

* fix

* add tests

* add per region example

* address comments

* Fix checking

* fix

* fix smoke test

* [LocalDockerBackend] Update `is_local_cluster` check for docker backend (#1396)

Update is_local_cluster check for LocalDockerBackend

* [Setup] unset CUDA_VISIBLE_DEVICES for detach setup (#1404)

* unset CUDA_VISIBLE_DEVICES

* add env check example

* Add setting CUDA_VISIBLE_DEVICES test

* fix

* Update sky/backends/cloud_vm_ray_backend.py

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* format

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* [Spot] Keep SKYPILOT_JOB_ID the same for the same spot job (#1400)

* fix SKYPILOT_JOB_ID

* Fix test

* fix

* format

* Add SKYPILOT_JOB_ID to sky spot queue

* nit

* don't set job_id_env_var for spot controller task

* address comments

* Revert SKYPILOT_JOB_ID in spot queue

* format

* Change default value of task.envs to dict

* [UX] fix the error for the first time `sky launch` (#1405)

* fix ux

* test

* fix no public cloud

* address comments

* Fix logging

* format

* Remove the error type for CLI

* yellow

* fix

* Fix logging

* [Spot] Fix spot recovery for multi node (#1411)

* Add cluster status check even job is RUNNING for multi-node

* Disable autoscaler logs and fix finished when partially preempted

* format

* Add test

* address comments

* update

* Add time

* [Release] Fix pypi description (#1416)

* Fix pypi description

* fix

* format

* [Bug fix] head_ip extraction from Ray stdout (#1421)

* Fix bug in head_ip extraction from Ray stdout after launching cluster by using regex to exactly match ip.

* Remove unneeded comment.

* Update sky/backends/cloud_vm_ray_backend.py

Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>

* Run yapf and pylint

Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>

* [Global Regions] Add data fetchers into wheel (#1406)

* Add data fetchers into wheel

* yapf

* Fix gcp fetcher

* Add check

* exclude analyze.py

* Link to blog on README and docs. (#1430)

* [Spot] Let cancel interrupt the spot job (#1414)

* Let cancel interrupt the job

* Add test

* Fix test

* Cancel early

* fix test

* fix test

* Fix exceptions

* pass test

* increase waiting time

* address comments

* add job id

* remove 'auto' in ray.init

* Revert "[Spot] Let cancel interrupt the spot job" (#1432)

Revert "[Spot] Let cancel interrupt the spot job (#1414)"

This reverts commit 3bbf4aa.

* [AWS] Avoid key pair permission issue by using cloud-init for authorized keys (#1427)

* Switch to UserData to add public key for AWS

* fix

* Avoid hardcoding username

* Fix backward compatibility test

* address comments

* address comments

* Minor spot logs fix: don't print job id not provided on spot launch. (#1434)

Minor spot logs fix: don't print job id not provided.

* [Catalog] Remove hardcoded A2 pricing URL & Fix a bug in A2 machine zones (#1426)

* Update no 16xA100-40GB zones

* [Catalog] Remove GCP A2 price URL & Fix GCP A100 zone issues

* Add more type annotations

* Minor

* yapf

* Do not add GCP URL prefix

* Minor

* Address comments

* Address comment1

* Minor

* Add comments about the case when a100.empty is True

* Assert not duplicated

* [Spot] Let cancel interrupt the spot job (#1414) (#1433)

* Let cancel interrupt the job

* Add test

* Fix test

* Cancel early

* fix test

* fix test

* Fix exceptions

* pass test

* increase waiting time

* address comments

* add job id

* remove 'auto' in ray.init

* Fix serialization problem

* refactor a bit

* Fix

* Add comments

* format

* pylint

* revert a format change

* Add docstr

* Move ray.init

* replace ray with multiprocess.Process

* Add test for setup cancelation

* Fix logging

* Fix test

* lint

* Use SIGTERM instead

* format

* Change exception type

* revert to KeyboardInterrupt

* remove

* Fix test

* fix test

* fix test

* typo

* [Usage] Robustify the user hash to avoid empty string (#1442)

* Robustify the user hash to avoid empty string

* fix

* Check valid user hash with hexdecimal

* format

* fix

* Add fallback

* Add comment

* lint

* [Storage] Support multiple files in Storage (#1311)

* Set rename_dir_lim for gcsfuse

* Add support for list of sources for Storage

* fix demo yaml

* tests

* lint

* lint

* test

* add validation

* address zhwu comments

* add error on basename conflicts

* use gsutil cp -n instead of gsutil rsync

* lint

* fix name

* parallelize gsutil rsync

* parallelize aws s3 rsync

* lint

* address comments

* refactor

* lint

* address comments

* update schema

* Logging fixes. (#1452)

* Logging fixes.

* yapf

* sys.exit(1)

* [Storage] Fix copy monuts for file with s3 bucket url (#1457)

* test file download with s3

* fix test

* fix storage file mounts

* format

* remove mkdir for `make_sync_dir_command`

* Print errors for GCP timeout. (#1454)

* [autostop] Support restarting the autostop timer. (#1458)

* [autostop] Support restarting the autostop timer.

* Logging

* Make each job submission call set_active_time_to_now().

* Fix test and pylint.

* Fix comments.

* Change tests; some fixes

* logging remnant

* remnant

* [Spot] Make sure the cluster status is not None when showing (#1464)

* Make sure the cluster status is not None when showing

* Fix another potential issue with NoneType of handle

* Add assert

* fix

* format

* Address comments

* Address comments

* format

* format

* fix

* fix

* fix spot cancellation

* format

* Add a few small warnings to README and CONTRIBUTING. (#1422)

* Add a couple small warnings to README and CONTRIBUTING.

* Update README.md

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>

* Hotfix for spot TPU pod recovery (#1470)

* hotfix

* comment

* [Spot] Better spot logs (#1412)

* Add cluster status check even job is RUNNING for multi-node

* Disable autoscaler logs and fix finished when partially preempted

* format

* Add test

* Better spot logging

* Add logs

* format

* address comments

* address comments part 2

* Finish the logging early

* format

* better logging

* Address comments

* Fix message

* Address comments

* Improve UX for logs to include SSH name and rank (#1380)

* Messy WIP

* Fixes two more yamls

* Improve log UX and ensure stableness

* Remove print statement

* Remove task name from logs

* Fix name for single-node tasks

* Update var names and comments for clarity

* Update logic for single and multi-node clusters

* Cache stable cluster IP list in ResourceHandle

* Properly cache and invalidate stable list

* Add back SKYPILOT_NODE_IPS

* Update log file name

* Refactor backend to use cached stable IP list

* Fix spot test

* Fix formatting

* Refactor ResourceHandle

* Fixes for correctness

* Remove unneeded num_nodes arg

* Fix _gang_schedule_ray_up

* Ensure stable IP list is cached

* Formatting fixes

* Refactor updating stable IPs to be part of handle

* Merge max attempts constant

* Fix ordering for setting TPU name

* Fix bugs and clean up code

* Fix backwards compatibility

* Fix bug with old autostopped clusters

* Fix comment

* Fix assertion statement

* Update assertion message

Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>

* Fix linting

* Fix retrieving IPs for TPU vm

* Add optimization for updating IPs

* Linting fix

* Update comment

Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>

* add cost tracking for clusters that handles launching, re-starting, getting status, stopping and downing clusters, but no auto-stopping

* fix some artifacts from rebase error

* handle linting

* make it cost-report

* address PR changes for approval

* last changes

* address last changes

* move around comments for sort

* add cost_report func to init.all list

Co-authored-by: Sumanth <sumanth@MacBook-Pro-5.local>
Co-authored-by: Sumanth <sumanth@MacBook-Pro-5.attlocal.net>
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Wei-Lin Chiang <infwinston@gmail.com>
Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>
Co-authored-by: Michael Luo <michael.luo@berkeley.edu>
Co-authored-by: Isaac Ong <isaacong.jw@gmail.com>
Co-authored-by: ewzeng <46831164+ewzeng@users.noreply.github.com>
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Co-authored-by: Donny Greenberg <dongreenberg2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin left review comments

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TPU/Spot] TPU pods fail to be launched after preempted
3 participants
@infwinston @concretevitamin @Michaelvll