[State] Disable WAL when running on WSL #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Thanks for the fix @romilbhardwaj! Could we have a TODO comment to note that the fix may cause the database locked problem on the WSL?
Just tested on mac OS 12.6 with the following:
(sky-dev) ➜ sky-experiment-dev (disable_wal) python ✱
Python 3.8.13 | packaged by conda-forge | (default, Mar 25 2022, 06:05:47)
[Clang 12.0.1 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from sky.utils import common_utils
>>> common_utils.is_wsl()
False
Seems working!
concretevitamin
approved these changes
Jan 10, 2023
|
|
||
| def is_wsl() -> bool: | ||
| """Detect if running under WSL""" | ||
| return 'microsoft' in platform.uname()[3].lower() |
There was a problem hiding this comment.
There was a problem hiding this comment.
This doesn't work on my machine:
>>> uname().release
'4.4.0-19041-Microsoft'
|
Thanks folks! Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enabled write ahead logging for state.db in #1513, but it breaks compatibility for WSL (
sqlite3.OperationalError: locking protocol; see wsl issue), particularly when running tests.This PR puts a check for WSL before enabling WAL on
state.db.Note that this "fix" is a band-aid. We may still see issues when WSL users try to access state.db concurrently from multiple processes.
This PR does not touch WAL for
skylet_config.db.Tested (run the relevant ones):
bash tests/run_smoke_tests.sh using_file_mounts) on WSL to ensure fix works