Show DEVICE_MEMORY in show-gpus for AWS & Lambda.
#1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Apr 2, 2023
Comment on lines
+3036
to
+3037
| device_memory_str = (f'{item.device_memory:.0f}GB' if | ||
| not pd.isna(item.device_memory) else '-') |
There was a problem hiding this comment.
What is the definition of device memory? IIRC, it is the amount of memory in a single device and does not depend on the device count, right? Then what about TPUs?
There was a problem hiding this comment.
Added some definition to -h. Wdyt? For TPU, we can defer adding documentation for it since we don't have that info in the catalog.
concretevitamin
commented
Apr 3, 2023
Comment on lines
+3036
to
+3037
| device_memory_str = (f'{item.device_memory:.0f}GB' if | ||
| not pd.isna(item.device_memory) else '-') |
There was a problem hiding this comment.
Added some definition to -h. Wdyt? For TPU, we can defer adding documentation for it since we don't have that info in the catalog.
WoosukKwon
reviewed
Apr 3, 2023
Comment on lines
+2943
to
+2946
| * ``DEVICE_MEM``: Memory of a single device; does not depend on the device | ||
| count of the instance (VM). | ||
|
|
||
| * ``HOST_MEM``: Memory of the host instance (VM). |
There was a problem hiding this comment.
nit: Do we need `` here?
There was a problem hiding this comment.
Yea, this doesn't look good on -h but is what's needed for rst/sphinx docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #1764: only AWS & Lambda catalogs have the relevant info for now.
Azure / GCP's offerings will show a
-under theDEVICE_MEMcolumn.Tested (run the relevant ones):
sky show-gpus -apytest tests/test_smoke.py --awspytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh