New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `is_empty` when disk tier is not None #2215

Merged

concretevitamin merged 1 commit into skypilot-org:master from cblmemo:fix-is-empty-disk-tier

Jul 12, 2023

Collaborator

cblmemo commented Jul 12, 2023

As shown in the title, this PR fixes the is_empty function in resources class when disk_tier is not None.

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh


          fix is empty for disk tier

a476456

concretevitamin approved these changes

View reviewed changes

concretevitamin merged commit 91a5ae4 into skypilot-org:master

15 checks passed

cblmemo deleted the fix-is-empty-disk-tier branch

July 12, 2023 18:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet