Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Fix test_multiple_buckets_creation_and_deletion from test_smoke.py #2259

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[Storage] Fix test_multiple_buckets_creation_and_deletion from test_smoke.py #2259

merged 1 commit into from
Jul 17, 2023

Conversation

landscapepainter
Copy link
Collaborator

@landscapepainter landscapepainter commented Jul 17, 2023 •
edited
Loading

This resolves #2258

This fixes by running sky storage delete on the storage objects created from the test rather than all with -a

Tested (run the relevant ones):

@landscapepainter landscapepainter changed the title fix test_multiple_buckets_creation_and_deletion [Storage] Fix test_multiple_buckets_creation_and_deletion from test_smoke.py Jul 17, 2023
romilbhardwaj
romilbhardwaj approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @landscapepainter!

@landscapepainter landscapepainter merged commit 5c2caee into skypilot-org:master Jul 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Storage] sky managed storages being deleted when smoke test for stroage ran
2 participants
@landscapepainter @romilbhardwaj