New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --disk-tier to be None to remove the disk_tier setup in yaml #2906

Merged

Michaelvll merged 2 commits into master from disk-tier-none

Dec 28, 2023

Collaborator

Michaelvll commented Dec 27, 2023

This is to enable sky launch --disk-tier none -c test-mixtral --cloud azure llm/mixtral/serve.yaml

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh


          Allow --disk-tier none to remove the disk_tier setup in yaml

731ff5b

Michaelvll requested a review from cblmemo

December 27, 2023 12:27


          format

9d5a257

cblmemo approved these changes

View reviewed changes

Collaborator

cblmemo left a comment

LGTM!

Michaelvll merged commit 6866e0d into master

19 checks passed

Michaelvll deleted the disk-tier-none branch

December 28, 2023 13:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet