better nc error message on mac #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix permissions * fix permissions
* Add serve for gemma and fix mixtral dependency * Add hf token * fix model len * Add comment * Serve your private gemma * fix serve yaml * readme * Remove chat completion due to the wrong template * add readme * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * address comments * Update README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Change to it * Add chat API * use HF_TOKEN env * typo --------- Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
* when removing cudo credential, sky check fails * remove tips * minor hint fix * fix cluster version for k8s * fix typo
…org#3218) * Add retry for docker pull due to daemon not ready * longer wait time * longer wait time * retry earlier * add retry for retries as well * longer wait time * change wait time * format * Add comment * Fix * Fix indent for azure docker config * Fix docker login config * Fix comments * More robust docker login config * Add retry for docker check * minor fix * Add additional test for stop and start with docker * Fix cancelled
…o hriday/unsloth # Conflicts: # README.md # docs/source/index.rst
shethhriday29
changed the title
romilbhardwaj
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution to #3001
Previously —
nc -hexits with error code -1 for macos default netcat, which causes our k8s dependency checks to fail. This failure is correct, since macos netcat does not support the-zflag and the user must install GNU netcat withbrew install netcat. However, some power users may be confused by this behavior since they know that netcat is already installed.This PR updates the error message so that if the default MacOS netcat is found, we acknowledge that in the message, but then direct the user to install GNU netcat via
brew install netcat.