[k8s] Add support for autoscaling kubernetes clusters #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
May 7, 2024
There was a problem hiding this comment.
Thanks for quickly adding this support @romilbhardwaj! Looks mostly good to me.
sky/cli.py
Outdated
Comment on lines
3051
to
3052
| if cloud_is_kubernetes and kubernetes_autoscaling: | ||
| yield kubernetes_utils.KUBERNETES_AUTOSCALER_NOTE |
There was a problem hiding this comment.
Does this mean when the cloud is not specified, i.e. None, we will not print the hint? Should we print the hint if cloud is None as well.
Also, in the show_all case, should we print this hint as well?
There was a problem hiding this comment.
ahh good point - fixed now! shown when cloud is not specified and also in show_all case.
Michaelvll
approved these changes
May 7, 2024
|
Thanks @Michaelvll! Tested on karpenter and GKE nodepool autoscaling, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
autoscalerfield to config.yaml to allow the user to specify the autoscaler used in the underlying kubernetes cluster:Setting this field:
When used in conjunction with
provision_timeout, this allows users to bring in their scale-to-zero k8s clusters and use them with SkyPilot.Currently supported autoscalers: GKE nodepools, Karpenter, any generic CA that can label new nodes with
skypilot.co/accelerator(Related - #3432)More context: https://docs.google.com/document/d/17LRYGCKDsY9AygAJbUIiQR4KkHZqSakL8G0SF7WNOR8/edit?usp=sharing
Tested (run the relevant ones):
bash format.sh