Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Breaking/Erroring of Promises #118

Merged
merged 20 commits into from
Mar 15, 2017
Merged

Added Breaking/Erroring of Promises #118

merged 20 commits into from
Mar 15, 2017

Commits on Mar 15, 2017

  1. Add ruining/breaking of promises

    2 unresolved issues:
    -actors.som (seems to be redundent)
    -what to do with an exception that is not caught.
    salenaer authored and smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    bc84f4b View commit details
    Browse the repository at this point in the history
  2. Added basic tracing or ruining/breaking of promies (untested)

    - adding tests for ruining
    - fixed explicit ruining
    - found problem with chaining and ruining
    
    RM tiny
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    salenaer authored and smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    8465991 View commit details
    Browse the repository at this point in the history
  3. Updated ruining to not throw error if unhandled

    - added tests for ruining
    - made ruining ruin all chained if not handled
    - made ruining ruin chained of own chained if not handled
    - currently bug causing two test to crash if run consequently
    - added four more test
    - finished nested ruining, tests still fail
    
    RM behavior
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    salenaer authored and smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    7a34ffa View commit details
    Browse the repository at this point in the history
  4. Changed errornous to erroneous

    salenaer authored and smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    6c6cd8e View commit details
    Browse the repository at this point in the history
  5. Fix code style issues

    - checkstyle errors
    - codacy errors
    salenaer authored and smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    f5dbbbb View commit details
    Browse the repository at this point in the history
  6. Apply refactorings from master branch

    - execution stats are kept in TracingActivityThread
    - chainedPromise seems to need frame for now
    - avoid using ‘ruin’, prefer ‘error’ or ‘break’ (work in progress)
    - trace broken promise like resolved ones
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    3e13b73 View commit details
    Browse the repository at this point in the history
  7. Remove Promise>>#on:do:

    The #on:do: method cannot be properly supported for promises, because registering handlers with filtering semantics is a racy operation.
    Depending on the order of events, a handler might or might not trigger because a filter might have been inplace. And, we don’t want to expose such races.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    9a4177b View commit details
    Browse the repository at this point in the history
  8. Remove dead code

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    fd74c1e View commit details
    Browse the repository at this point in the history
  9. Enable old tests, with Newspeak background

    - revise them, still were using old naming
    - adapt assert in Minitest, too
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    33dc3b1 View commit details
    Browse the repository at this point in the history
  10. Fix broken error handling in Minitests for broken promises

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    931a125 View commit details
    Browse the repository at this point in the history
  11. Revise promise interface and documentation

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    3e93afc View commit details
    Browse the repository at this point in the history
  12. Remove code that’s duplicated for error case

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    cfd7333 View commit details
    Browse the repository at this point in the history
  13. Enable promise erroring tests

    - fix up terminology to avoid ruin
    - fix some simple issues
    - fix code style
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    ef1d04a View commit details
    Browse the repository at this point in the history
  14. Fix parse errors in Actors.som

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    c3808db View commit details
    Browse the repository at this point in the history
  15. Fix parse errors and bugs in ActorTests

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    5e9f442 View commit details
    Browse the repository at this point in the history
  16. Reactor implementation of breaking/erroring of promises

    - avoid code duplication, reusued normal resolution, and use Resolution as argument to distinguish
    - introduce common AbstractPromiseResolutionNode to reuse code between successful and erroneous resolution
    - use RegisterOnError node to optimize callback registration, same as RegisterWhenResolved
    - check resolution type when resolving callbacks
    - propagate breakpoint info
    - use same implementation strategy for OnErrorPrim as for normal WhenResolvedPrim
    - add promise error parsing to trace parsing
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    694468c View commit details
    Browse the repository at this point in the history
  17. Fix bug in CachedDnuNode, didn’t set nextInCache

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    4b78b05 View commit details
    Browse the repository at this point in the history
  18. Updated Dynamic Metrics tool test data after changes to core-lib

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    1c09955 View commit details
    Browse the repository at this point in the history
  19. Delete old all.gcov file when updating coverage data

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    9ad0d10 View commit details
    Browse the repository at this point in the history
  20. Added CHANGELOG entry

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    ed393bc View commit details
    Browse the repository at this point in the history