Optimized Tracing and Restoring Replay Support #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t write currentActor in every actorContext recording This seems just in the wrong place, and just writes itself, even if not necessary. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This one is needed for all buffer changes Remove recordActorCreation, was replaced by node Signed-off-by: Stefan Marr <git@stefan-marr.de>
Reduce code duplication in received message handling Move more of the old tracing also intro the received call targets Factor our redundant code Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This avoids many recurring specializations in the tracing nodes we need. Signed-off-by: Stefan Marr <git@stefan-marr.de>
[Fix] id tracing, remove unneeded code Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
ByteBuffer didn’t do much useful things, and cost another indirection for tracing. Let’s see whether this makes any difference. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
reviewed
Jul 23, 2018
| @@ -302,9 +302,6 @@ private void execute(final EventualMessage msg, | |||
| if (VmSettings.KOMPOS_TRACING) { | |||
| KomposTrace.scopeEnd(DynamicScopeType.TURN); | |||
| } | |||
| if (VmSettings.ACTOR_TRACING) { | |||
| ActorExecutionTrace.recordMessage(msg); | |||
| } | |||
There was a problem hiding this comment.
yes, messages are now traced in ReceivedRootNode.
- add options for constants - make buffer recycling optional
smarr
force-pushed
the
Tracing-and-Replay-Infrastructure
branch
from
109d8d8
to
a1479ab
Compare
smarr
added
the
enhancement
smarr
approved these changes
Jul 23, 2018
smarr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the second half of the changes to the tracing implementation.
The changes include a move away from ByteBuffer, instead byte arrays and unsafe are used.
Furthermore, Truffle Nodes are used for tracing to achieve lower overhead.