Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #275

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Remove dead code #275

merged 1 commit into from
Oct 30, 2018

Conversation

fniephaus
Copy link
Contributor

Could not find any references to genericAccessTarget.

@smarr smarr changed the base branch from release to dev October 19, 2018 16:40
@smarr
Copy link
Owner

smarr commented Oct 19, 2018

Reset based branch from release to dev, hope those tests pass.

@fniephaus @smarr
Remove dead code
6d685d8 
Could not find any references to `genericAccessTarget`.
@smarr smarr added this to the v0.7.0 milestone Oct 30, 2018
@smarr smarr added the enhancement Improves the implementation with something noteworthy label Oct 30, 2018
@smarr smarr self-assigned this Oct 30, 2018
@smarr smarr merged commit 20f68fd into smarr:dev Oct 30, 2018
@smarr
Copy link
Owner

smarr commented Oct 30, 2018

Thanks. After rebasing it on dev, things work as expected.

@fniephaus fniephaus deleted the patch-1 branch November 5, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarr smarr

Labels
enhancement Improves the implementation with something noteworthy
Projects
None yet
Milestone
v0.7.0 - Extension Modules, Snapshots...
Development

Successfully merging this pull request may close these issues.
2 participants
@fniephaus @smarr