Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Truffle to >19.0.1 release #298

Merged
merged 24 commits into from
Jun 30, 2019
Merged

Update Truffle to >19.0.1 release #298

merged 24 commits into from
Jun 30, 2019

Conversation

smarr
Copy link
Owner

@smarr smarr commented Jun 28, 2019

This PR gets us onto the latest Truffle version.
There are various little changes, some of which may have bigger impact down the line.

  • The interop support is now even more minimal than before, but, it seems sufficient for debugging, and for everything that's currently tested.
  • This PR also restore testing on macOS.
  • We use now mx native-image which simplifies image generation and avoids having to maintain dependencies manually.

@daumayr would be great if you could give this a spin and see whether it works on your machine.

smarr added 22 commits June 28, 2019 10:46
- also updated mx accordingly

Signed-off-by: Stefan Marr <git@stefan-marr.de>
- account for removal of frame descriptor from slot
- don't use deprecated FrameSlot.getIndex()

Signed-off-by: Stefan Marr <git@stefan-marr.de>
This may need extra support for other JDK versions.

- fixed in build files
- fixed in launcher script

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…ocessor

Did not verify

Signed-off-by: Stefan Marr <git@stefan-marr.de>
- nested classes do not generate code any more, might be fixed later?
- classes need specializations to generated code, specialization in abstract super class is not sufficient

Signed-off-by: Stefan Marr <git@stefan-marr.de>
- implement isNull in new interop
- remove outdated isInstance

Signed-off-by: Stefan Marr <git@stefan-marr.de>
- need to enter TruffleContext explicitly on worker threads
  - needed for instrumentation etc

- initiate shutdown explicitly via an eval.
  This avoids races and makes sure the f/j pools are in a known state.
  The drawback of this approach is that we need an extra .eval() call before we can close the context.

- use TruffleContext instead of Context inside of SOMns

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- top level folder in tar can be named not following expected pattern

Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is to avoid breaking tests by Truffle changing some toString format.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
The changes to the debugging session require to use the new support for root elements, otherwise, our root-element-based breakpoints would not work.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…tually

Signed-off-by: Stefan Marr <git@stefan-marr.de>
- use xcode9.3 image for Java 8
- install ant
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…nterp

Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr smarr added the enhancement Improves the implementation with something noteworthy label Jun 28, 2019
@smarr smarr added this to the v0.7.0 milestone Jun 28, 2019
@smarr smarr self-assigned this Jun 28, 2019
@smarr
Copy link
Owner Author

smarr commented Jun 28, 2019

@fniephaus possibly relevant for you, too.

@Richard-Roberts @kjx @IsaacOscar @Jamigrith: this is a major update of Truffle, and we might want to consider this for https://github.com/gracelang/moth-SOMns It allows to use the officially released GraalVM 19

@smarr smarr force-pushed the truffle-update branch 3 times, most recently from f3a1a8f to 48ebdb1 Compare June 30, 2019 14:52
- remove it from .travis.yml
- use the new libs/jvmci folder in ./som launcher
- remove “known” locations to guess where a GRAAL/JVMCI_BIN is
- adapt order to find JVMCI bin to use more relevant/explicit settings first
- use it also for benchmarks

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr smarr merged commit d9d8492 into dev Jun 30, 2019
@smarr smarr deleted the truffle-update branch June 30, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the implementation with something noteworthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants