Optimize Single Message Processing in Mailbox #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daumayr
force-pushed
the
mailbox-alternative
branch
9 times, most recently
from
c9eaa0e
to
988efea
Compare
smarr
requested changes
Jan 24, 2017
| @@ -57,7 +59,11 @@ public static Actor createActor() { | |||
| private static final int THREAD_ID_SHIFT = 56; | |||
|
|
|||
| /** Buffer for incoming messages. */ | |||
| private Mailbox mailbox = Mailbox.createNewMailbox(16); | |||
| private EventualMessage message; | |||
There was a problem hiding this comment.
Hm, perhaps this would be better firstMessage, to make the semantics clear.
And, I think the comment could be extended to say that we optimize the case that there is one message, and only put everything afterwards into the moreMessages data structure.
| @@ -57,7 +59,11 @@ public static Actor createActor() { | |||
| private static final int THREAD_ID_SHIFT = 56; | |||
|
|
|||
| /** Buffer for incoming messages. */ | |||
| private Mailbox mailbox = Mailbox.createNewMailbox(16); | |||
| private EventualMessage message; | |||
| private List<EventualMessage> moreMessages; | |||
There was a problem hiding this comment.
Why do you use an ArrayList here, instead of a Mailbox, any specific reason?
Mailbox was implemented to avoid copying the array of ArrayList when the mailbox becomes to small.
Perhaps a better name would be mailboxExtension. The code below doesn't read well at the moment, from the perspective of terminology/word choice.
| private EventualMessage message; | ||
| private List<EventualMessage> moreMessages; | ||
|
|
||
| private long sendTimeStamp; |
| private List<EventualMessage> moreMessages; | ||
|
|
||
| private long sendTimeStamp; | ||
| private List<Long> moreSendTimeStamps; |
| sendTimeStamp = System.currentTimeMillis(); | ||
| } | ||
| } else { | ||
| sendMoreMessages(msg); |
| /** | ||
| * Is scheduled on the fork/join pool and executes messages for a specific | ||
| * actor. | ||
| */ | ||
| private static final class ExecAllMessages implements Runnable { | ||
| private final Actor actor; | ||
| private Mailbox current; | ||
| private EventualMessage current; |
| /** | ||
| * Is scheduled on the fork/join pool and executes messages for a specific | ||
| * actor. | ||
| */ | ||
| private static final class ExecAllMessages implements Runnable { | ||
| private final Actor actor; | ||
| private Mailbox current; | ||
| private EventualMessage current; | ||
| private List<EventualMessage> moreCurrent; |
| private EventualMessage current; | ||
| private List<EventualMessage> moreCurrent; | ||
| private long baseMessageId; | ||
| private long sendTimeStamp; |
There was a problem hiding this comment.
and for the time stamps, same wording as above, please
| int i = 0; | ||
| if (size > 1) { | ||
| for (EventualMessage msg : moreCurrent) { | ||
| actor.logMessageBeingExecuted(msg); |
There was a problem hiding this comment.
this block looks identical to the handling of the first message. could this be a helper method?
daumayr
force-pushed
the
mailbox-alternative
branch
3 times, most recently
from
2963bba
to
4191ede
Compare
daumayr
force-pushed
the
mailbox-alternative
branch
from
4191ede
to
416eece
Compare
smarr
changed the title
now uses SPromise like queuing
Fixed Validition.Philosophers resolving promise twice. Fixed RejectedExecutionException when sending messages while shutting down, throw ThreadDeath instead.
smarr
force-pushed
the
mailbox-alternative
branch
from
416eece
to
74ce078
Compare
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the current Mailbox implementation with a approach similar to how SPromise handles chained Promises. This brings a performance improvement due to currently low mailbox utilization (many contain only one message).