Use '__DIR__' instead of 'dirname(__FILE__)' #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisskid
approved these changes
Sep 27, 2022
MekDrop
deleted the
improvement/dirname(__FILE__)-convert-into-__DIR__
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings fewer parentheses ;)
Smarty at the current moment needs at least PHP 7.1, so we can use
__DIR__instead ofdirname(__FILE__). This makes the code a bit easier to read - fewer parentheses and also adds a micro-optimization for resolving directories - no function calls are needed because all paths resolving happens at compiling time.It's not much but I hope this could be useful.