Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated collection.py to resolve issue #6 on snyk-labs/snyk-tags-tool #7

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

jonesjim
Copy link
Contributor

When customBranch is enabled, Snyk Code projects assume the name of TargetName + "()". Other projects generally consist of TargetName + (in the case of customBranch) "()" + ":" + path/to/file. Currently, apply_tags_to_projects is only checking for TargetName + either ":" or "(" which solves most use cases, but when customBranch is disabled, Snyk Code projects assume the name of TargetName.

This PR is intended to add the condition for project name = target name. Attaching screenshots for scenario testing.
Screen Shot 2022-11-10 at 5 47 01 PM
Screen Shot 2022-11-10 at 5 48 03 PM
Screen Shot 2022-11-10 at 5 48 24 PM
Screen Shot 2022-11-10 at 5 53 26 PM
Screen Shot 2022-11-10 at 5 54 48 PM

@EricFernandezSnyk EricFernandezSnyk merged commit 4fa4a83 into snyk-labs:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants