fix issue: Specified key was too long; max key length is 3072 bytes

[huan11]

Motivation:

Fix script issue when run under mysql

Reference:

SQL issue-[Script issue]: Specified key was too long; max key length is 3072 bytes

Summary by CodeRabbit

• Refactor
  • Reduced the maximum length of data_center and remote_data_center fields from 512 to 255 characters in the multi_cluster_sync_info table, optimizing storage and improving performance.

[sofastack-cla]

Hi @huan11, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

[coderabbitai]

Walkthrough

The changes in the create_table.sql file adjust the column lengths for data_center and remote_data_center within the multi_cluster_sync_info table from 512 to 255 characters. This modification optimizes the storage by reducing the maximum allowed length of these strings.

Changes

File	Change Summary
...create_table.sql	Updated data_center and remote_data_center columns' varchar length from 512 to 255

Poem

In the bytes of code and tables grand,
We trimmed the strings with gentle hand.
Data centers now fit just right,
Space saved without a fight.
Optimization, light and swift,
The code, it catches data's drift.
🌟✨🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0d4ffd5 and a9fbc2b.

Files selected for processing (1)

• create_table.sql (1 hunks)

Additional comments not posted (1)

create_table.sql (1)

92-93: LGTM! But verify the impact on stored data.

The code changes are approved.

However, ensure that the reduction in varchar length for data_center and remote_data_center does not truncate any existing data in these columns.

[NickNYU]

@huan11 please sign CLA as guide, thx

[huan11]

@NickNYU
I have already signed yesterday, seem your pipeline have some issue now.