New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to check serialization and deserialization #1898

Merged

adamw merged 9 commits into master from 1862_Bady_serializer_for_JSON_AST_types

Jul 24, 2023

Contributor

PanHNE commented Jul 14, 2023 •

edited

Loading


          Add companion object to SttpUpickleApi and add test to show how impli…

8e0846c

…cit works

adamw reviewed

View reviewed changes

json/upickle/src/main/scala/sttp/client4/upicklejson/SttpUpickleApi.scala Outdated Show resolved Hide resolved

Adrian Domin added 2 commits

July 18, 2023 09:57


          Remove unnecessary things

dea0475


          Add tests to check serialization and deserialization

97b37e1

PanHNE changed the title ~~Add companion objects for serializers~~ Add tests to check serialization and deserialization

PanHNE requested a review from adamw

July 18, 2023 10:32

wydra98 reviewed

View reviewed changes

json/jsoniter/src/test/scala/sttp/client4/jsoniter/BackendStubJsoniterTests.scala Show resolved Hide resolved

wydra98 reviewed

View reviewed changes

json/play-json/src/test/scala/sttp/client4/BackendStubPlayJsonTests.scala Outdated Show resolved Hide resolved

wydra98 reviewed

View reviewed changes

json/circe/src/test/scala/sttp/client4/circe/BackendStubCirceTests.scala Outdated Show resolved Hide resolved

wydra98 reviewed

View reviewed changes

json/json4s/src/test/scala/sttp/client4/BackendStubJson4sTests.scala Outdated Show resolved Hide resolved

wydra98 reviewed

View reviewed changes

json/play-json/src/test/scala/sttp/client4/BackendStubPlayJsonTests.scala Outdated Show resolved Hide resolved

wydra98 reviewed

View reviewed changes

json/spray-json/src/test/scala/sttp/client4/BackendStubSprayJsonTests.scala Outdated Show resolved Hide resolved


          Corrections after CR

ebcc0f6

PanHNE requested a review from wydra98

July 19, 2023 05:22

adamw reviewed

View reviewed changes

json/circe/src/test/scala/sttp/client4/circe/BackendStubCirceTests.scala Outdated Show resolved Hide resolved


          Corrects tests

f6f2fe4

PanHNE requested a review from adamw

July 21, 2023 12:59

adamw reviewed

View reviewed changes

json/circe/src/test/scala/sttp/client4/circe/BackendStubCirceTests.scala Outdated Show resolved Hide resolved


          Move serialize's tests

b5f3084

PanHNE requested a review from adamw

July 24, 2023 06:12


          Remove unused imports

38755a0

Member

adamw commented Jul 24, 2023

The code doesn't even compile...

Adrian Domin added 2 commits

July 24, 2023 09:21


          Remove test to check jobs in github

0242e73


          Add test to circe and remove import to check behavior on github for s…

f642903

…cala 3

adamw merged commit 23b69a3 into master

15 checks passed

Member

adamw commented Jul 24, 2023

Thanks!

mergify bot deleted the 1862_Bady_serializer_for_JSON_AST_types branch

July 24, 2023 11:28

Member

adamw commented Jul 24, 2023

actually, there's on emore thing @PanHNE : we don't check if the content-type on the request is set to application/json, as it should be

PanHNE mentioned this pull request

Add serialize's tests #1907

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet