Governance: time to vote eneded calculates with cool off time #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract of SPL Gov works with cool off time to assert if it's time to finalize vote. https://github.com/solana-labs/solana-program-library/blob/master/governance/program/src/state/proposal.rs#L340 While there is the greater than not with 'equal' in comparision.
|
@ochaloup is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -946,12 +946,13 @@ export class Proposal { | |||
| return this.isPreVotingState() | |||
| ? governance.config.maxVotingTime | |||
| : (this.votingAt?.toNumber() ?? 0) + | |||
| governance.config.maxVotingTime - | |||
| governance.config.maxVotingTime + | |||
| governance.config.votingCoolOffTime - | |||
There was a problem hiding this comment.
votingCoolOffTime should be applied in both cases.
A better way to do this would be to rename maxVotingTime to baseVotingTime and then have a function for maxVotingTime -> baseVotingTime + votingCoolOffTime
|
@SebastianBor thanks for the review. I updated the pull request trying to follow your point. Please take a look.
|
|
Related change: https://github.com/solana-labs/oyster/pull/581/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract of SPL Gov works with cool off time to assert if it's time to finalize vote.
https://github.com/solana-labs/solana-program-library/blob/master/governance/program/src/state/proposal.rs#L340 While there is the greater than not with 'equal' in comparision.