Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[token-client] Make close_context_state_account and close_record_account variable order consistent #7174

Merged

Conversation

samkim-crypto
Copy link
Contributor

@samkim-crypto samkim-crypto commented Aug 21, 2024

Problem

There is an inconsistency in the parameter orders between the confidential_transfer_close_context_state and confidential_transfer_close_record_account functions.

  • In confidential_transfer_close_context_state, the lamport destination account is before the context state authority
  • In confidential_transfer_close_record_account, the lamport destination comes after the context state authority

Summary of Changes

I updated confidential_transfer_close_record_account function to follow the confidential_transfer_close_context_state function. I also updated the confidential_transfer_close_context_state function name to confidential_transfer_close_context_state_account to be more consistent with the other functions.

@samkim-crypto samkim-crypto marked this pull request as ready for review August 21, 2024 09:56
joncinque
joncinque previously approved these changes Aug 21, 2024
@mergify mergify bot dismissed joncinque’s stale review August 21, 2024 12:12

Pull request has been modified.

@samkim-crypto samkim-crypto merged commit 69257a6 into solana-labs:master Aug 21, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants