Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specs removing unnecessary destroys because of database_cleaner #10

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Update specs removing unnecessary destroys because of database_cleaner #10

merged 1 commit into from
Jan 23, 2020

Conversation

blocknotes
Copy link
Contributor

No description provided.

@blocknotes blocknotes self-assigned this Jan 20, 2020
@blocknotes blocknotes mentioned this pull request Jan 20, 2020
Closed
21 tasks
@blocknotes blocknotes force-pushed the mr/database-cleaner branch 2 times, most recently from 6e14988 to ab88944 Compare January 21, 2020 08:08
@blocknotes blocknotes changed the title Add database_cleaner Update specs removing unnecessary destroys because of database_cleaner Jan 21, 2020
@blocknotes blocknotes requested a review from elia January 23, 2020 13:12
elia
elia approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I caught a couple of typos…
Green light once those are fixed ✅ 👍

spec/features/solidus_importer/import_spec.rb Outdated Show resolved Hide resolved
spec/features/solidus_importer/import_spec.rb Outdated Show resolved Hide resolved
@blocknotes blocknotes merged commit 0dd45d1 into master Jan 23, 2020
@blocknotes blocknotes deleted the mr/database-cleaner branch January 23, 2020 15:50
@elia elia added this to the v1.0 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees

@blocknotes blocknotes

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@blocknotes @elia