Fix product/variant processors according to Shopify Product CSVs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinasMazar
force-pushed
the
mm/fix-import
branch
from
17cb813
to
e479f18
Compare
elia
requested changes
Apr 17, 2020
| product.slug = @data['Handle'] | ||
| product.price = options[:price] | ||
| product.shipping_category = options[:shipping_category] | ||
| end.tap do |product| |
| def prepare_variant(product) | ||
| Spree::Variant.find_or_initialize_by(sku: @data['Variant SKU']) do |variant| | ||
| def prepare_variant | ||
| @prepare_variant ||= Spree::Variant.find_or_initialize_by(sku: sku) do |variant| |
There was a problem hiding this comment.
Looks like Shopify bases the variant identity on the product + the name of the first option-value, maybe we should do the same, e.g.:
- update the master variant if the incoming data is for a master-variant
- use "Option1 Value" to identify the variant and maybe also to generate the sku when missing (E.g.:
"#{product.slug}-#{@data["Option1 Value"].parameterize}")
MinasMazar
pushed a commit
that referenced
this pull request
Apr 17, 2020
MinasMazar
pushed a commit
that referenced
this pull request
Apr 17, 2020
elia
approved these changes
Apr 17, 2020
added 2 commits
April 17, 2020 19:11
Refs. - https://github.com/shopifypartners/product-csvs.git - https://www.shopify.com/partners/blog/shopify-upload-products-csv These new examples are failing. We fix in next commits.
I found some product export sample CSV files in [this repository](https://github.com/shopifypartners/product-csvs.git). I've added some spec examples to test our import against those files. These tests are failing, so we need to change some of our assumptions about import logic: + `Variant SKU` is optional, so if present use it, generate new one otherwise. + when `Title` field is present we update a product. + when no `OptionValue1` is blank or `Default Title`, we update the master variant.
MinasMazar
force-pushed
the
mm/fix-import
branch
from
24f0d73
to
9293e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some product export sample CSV files in this repository.
I've added some spec examples to test our import against those files. These tests are failing, so we need to change some of our assumptions about import logic:
Variant SKUis optional, so if present use it, generate new one otherwise.Titlefield is present we update a product.OptionValue1is blank orDefault Title, we update the master variant.This also resolve #16