Update to the latest dev-support template and allow usage of Solidus 3.0 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinasMazar
force-pushed
the
mm/update_dev_support
branch
from
45f082a
to
5e8b5c4
Compare
MinasMazar
force-pushed
the
mm/update_dev_support
branch
2 times, most recently
from
010e83b
to
ce62436
Compare
added 3 commits
January 22, 2021 18:21
- disable Rubocop rule `MultipleExpectations` - correct Rubocop offence: avoid use of `let!` - disable Rubocop rule: `RSpec/MultipleMemoizedHelpers` - raise limit for `RSpec/NestedGroups` rule - explicitly name example subject - start context description with "when" - prefer `have_received` to test spies - appease [`Security/Open` rule][rubydoc-rule] [rubydoc-rule]: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/Open
MinasMazar
force-pushed
the
mm/update_dev_support
branch
from
ce62436
to
7675b4f
Compare
This is using the new SolidusSupport helper method to determine when using one or the other version. Refs. - [Solidus RFC](solidusio/solidus#3234) - [Solidus 3.0 Extensions Hackathon](solidusio/solidus#3911)
MinasMazar
force-pushed
the
mm/update_dev_support
branch
from
7263ed8
to
f3d0ac4
Compare
MinasMazar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to solidus_dev_support 2.3.0. Also prepare extension for Solidus 3.0.
Refs.