Many changes to reduce false positives and more: #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
justbbetter
commented
Nov 28, 2017
justbbetter
commented
- made DIGITS more restrictive: only 4+ consecutive digits
- match NAME only in saluation and valediction contexts
- company names are not really sensitive to don't redact them
- add SSN pattern
JaredBett
approved these changes
Nov 28, 2017
* made DIGITS more restrictive: only 4+ consecutive digits * match NAME only in saluation and valediction contexts * company names are not really sensitive to don't redact them * add SSN pattern
justbbetter
force-pushed
the
justin-reduce-false-positives
branch
from
16afec3
to
bfc41a7
Compare
|
just a friendly tip for next time since it seems like a few others have picked up the library (#10), when options are removed it's nice to publish in new major version (just need to put solvvy ❤️s OSS 😄 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.