This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Remove deprecated ReST API with dependencies #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wojciech Błoszyk <wbloszyk@gmail.com>
I think about it too. In NewsBundle we use pagination in frontend. We can remove datagrid bundle in favor of KnpPaginationBundle. I will wait with it for now. |
The DatagridBundle pagination was supposed to be only used for API. For frontend, there is already a Pager/Datagrid class in the AdminBundle (and his persistence bundle), made for this. |
Signed-off-by: Wojciech Błoszyk <wbloszyk@gmail.com>
|
Ready to review. |
Signed-off-by: Wojciech Błoszyk <wbloszyk@gmail.com>
core23
suggested changes
Sep 25, 2021
core23
suggested changes
Sep 25, 2021
VincentLanglet
approved these changes
Sep 25, 2021
core23
approved these changes
Sep 25, 2021
|
Thanks |
This was referenced Sep 25, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Remove ReST API with dependencies and update routing with tests.
Remove DatagridBundle with replace Pager by custom Pager (to allow use news without AdminBundle)
I am targeting this branch, because this should be done in unstable branch.