-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple and Deprecate notification bundle from create snapshot code #1418
Decouple and Deprecate notification bundle from create snapshot code #1418
Conversation
1ac060d
to
80b5bd3
Compare
Note: I'll check all suggestion added in my PR, I didn't forgot this :D |
Ok, just a explanation about future remove for this piece of code I'm trying to coverage the maybe in the past it worked different or maybe it get a different behaviour int his PR just for your information :) |
Indeed, prior to this PR, this was working. |
But this is not necessary, because if you pass it's handled here : https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Command/BaseCommand.php#L107 Edit 1: it'll work for |
Indeed, you might remove the else then. (and the if check) |
80b5bd3
to
3e42955
Compare
5908777
to
a962e8f
Compare
…ce.php and maybe refactor CreateSnapshotService
a962e8f
to
767dd45
Compare
d154eff
to
3ee2a12
Compare
452eddd
to
b014e9d
Compare
ead67f2
to
e2b7095
Compare
e2b7095
to
f895cda
Compare
ae9b701
to
7de3963
Compare
eeacd15
to
2e1c5af
Compare
15933b5
to
2733146
Compare
2733146
to
8fe3913
Compare
@eerison I added a commit to show you how this could be done, if you want to take a look. |
Ok I'll check ;) Edit 1: Hey @VincentLanglet I checked your changes and almost the whole code is necessary, I just removed 1 mock and added some |
Then, Am I wrong or is it ready to be merged ? |
Yes it's ready to merge ;) |
Ok, I'll wait for @jordisala1991 review |
Thanks @eerison , really good work! |
We missed something here, this other command also uses notificationBundle to work: https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Command/CleanupSnapshotsCommand.php |
Hey @jordisala1991 no I didn't missed this, I will create a PR for this cleanup too, I didn't do this here, because it will be too big |
Decouple and Deprecate notification bundle from create snapshot code
I am targeting this branch, because NoficationBundle code wasn't deprecated.
Issues #1415.
Changelog
To do
Create Snapshot
CreateSnapshotAdminExtension
is used, and remove notification bundle from there (it was added here: 2365702)