Decouple and Deprecate notification bundle from create snapshot code

[eerison]

Decouple and Deprecate notification bundle from create snapshot code

I am targeting this branch, because NoficationBundle code wasn't deprecated.

Issues #1415.

Changelog

### Added
- Added `CreateSnapshotService` to create snapshots
- Added `CreateSnapshotBySiteInterface`
- Added `CreateSnapshotByPageInterface`

### Deprecated
- Deprecated `async` mode in `CreateSnapshotsCommand`
- Deprecated `sonata.notification.backend` code into `SiteAdminController`
- Deprecated `sonata.notification.backend` code into `PageAdminController`
- Deprecated `sendMessage` and `$backend` property into the `CreateSnapshotAdminExtension`

To do

Create Snapshot

• Created test for create snapshot
• Add BC in create snapshot command
• Decouple NotificationBundle for create snapshot
• Create snapshot by command line
• see where CreateSnapshotAdminExtension is used, and remove notification bundle from there (it was added here: 2365702)
• Create snapshot, page, and site by admin (it was leading some strange behaviour )
• Edit doc (remove --site=all, because it's the default value)
• Fix pipelines
• validate the same create snapshot behaviour from 3.x branch
• Add --site=all, just to provide a security execution like "doctrine:schema:update --force"

[eerison]

Note: I'll check all suggestion added in my PR, I didn't forgot this :D

[eerison]

Ok, just a explanation about future remove for this piece of code

https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Command/CreateSnapshotsCommand.php#L69-L75

I'm trying to coverage the CreateSnapshotsCommand.php before make changes, and I can not coverage this else condition, the reason: when we pass one value or more in --site, always it'll be an array, then never it'll be equals all (and enter into the "else")

maybe in the past it worked different or maybe it get a different behaviour int his PR

just for your information :)

[VincentLanglet]

maybe in the past it worked different or maybe it get a different behaviour int his PR

Indeed, prior to this PR, this was working.
Now the check would be !\in_array('all', ....)

[eerison]

maybe in the past it worked different or maybe it get a different behaviour int his PR

Indeed, prior to this PR, this was working. Now the check would be !\in_array('all', ....)

But this is not necessary, because if you pass all, it will return all sites and it'll create the snaps shots

it's handled here : https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Command/BaseCommand.php#L107

Edit 1: it'll work for 1 site, many sites or all we don't need this else to call the same command, and it's working without this "else" ;)

[VincentLanglet]

Indeed, you might remove the else then. (and the if check)

[VincentLanglet]

@eerison I added a commit to show you how this could be done, if you want to take a look.
I'm pretty sure I mocked too many things though.

[eerison]

@eerison I added a commit to show you how this could be done, if you want to take a look. I'm pretty sure I mocked too many things though.

Ok I'll check ;)

Edit 1: Hey @VincentLanglet I checked your changes and almost the whole code is necessary, I just removed 1 mock and added some NEXT_MAJOR comments. and it's covering the changes that I made in batchActionSnapshot.

[VincentLanglet]

@eerison I added a commit to show you how this could be done, if you want to take a look. I'm pretty sure I mocked too many things though.

Ok I'll check ;)

Edit 1: Hey @VincentLanglet I checked your changes and almost the whole code is necessary, I just removed 1 mock and added some NEXT_MAJOR comments. and it's covering the changes that I made in batchActionSnapshot.

Then, Am I wrong or is it ready to be merged ?

[eerison]

@eerison I added a commit to show you how this could be done, if you want to take a look. I'm pretty sure I mocked too many things though.

Ok I'll check ;)
Edit 1: Hey @VincentLanglet I checked your changes and almost the whole code is necessary, I just removed 1 mock and added some NEXT_MAJOR comments. and it's covering the changes that I made in batchActionSnapshot.

Then, Am I wrong or is it ready to be merged ?

Yes it's ready to merge ;)

[VincentLanglet]

Ok, I'll wait for @jordisala1991 review

[jordisala1991]

Thanks @eerison , really good work!

[jordisala1991]

We missed something here, this other command also uses notificationBundle to work: https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Command/CleanupSnapshotsCommand.php

[eerison]

We missed something here, this other command also uses notificationBundle to work: https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Command/CleanupSnapshotsCommand.php

Hey @jordisala1991 no I didn't missed this, I will create a PR for this cleanup too, I didn't do this here, because it will be too big