Increase PHPStan to level 8 #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
hotfix/increase-phpstan-8
branch
2 times, most recently
from
ef13f68
to
e932873
Compare
jordisala1991
force-pushed
the
hotfix/increase-phpstan-8
branch
3 times, most recently
from
7886280
to
66fd634
Compare
jordisala1991
force-pushed
the
hotfix/increase-phpstan-8
branch
from
66fd634
to
4b416e1
Compare
|
This one is probably a bit harder to review, had to change some logics around to avoid null variables @VincentLanglet . Not sure if I followed the best option in each specific case. |
VincentLanglet
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this can only be applied to 4.x.
Changelog