Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise frontend code #1559

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Aug 15, 2022

Subject

I am targeting this branch, because this is BC break.

Changelog

### Changed
- Change frontend compilation system from Gulp to Webpack
- Change final minified file to `app.js` and `app.css`

@jordisala1991
Copy link
Member Author

Your latest PR on admin bundle might have break some builds @VincentLanglet

@VincentLanglet
Copy link
Member

Your latest PR on admin bundle might have break some builds @VincentLanglet

I'm using the modelManager in some methods now, so if it's not set in unit test it will fail indeed.

@VincentLanglet
Copy link
Member

#1560

@jordisala1991
Copy link
Member Author

Two things fixed here (besides the full migrations and upgrade of the code to be a little better):

  • Composer page now kinda works (not it does not fail on the js part, but rather when saving blocks on the PHP part, to see on another PR)
  • Layout is a bit better on Sonata, before it was a bit broken on some parts.

cc @eerison

@VincentLanglet VincentLanglet merged commit dd06055 into sonata-project:4.x Aug 15, 2022
@VincentLanglet
Copy link
Member

Nice job

@jordisala1991 jordisala1991 deleted the feature/modernise-frontend branch August 15, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants