Fix tool 'semgrep' warning for security reason.

Signed-off-by: Clark Lee <guizhao.lh@alibaba-inc.com>
sonic-net · Mar 1, 2023 · f40e481 · f40e481
1 parent 71a7e69
commit f40e481
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/sonic-pit/pit-sysdiag/src/function.py b/src/sonic-pit/pit-sysdiag/src/function.py
@@ -38,15 +38,15 @@ def convert_unicode(input):
 
 
 def run_command(cmd):
-    proc = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+    proc = subprocess.Popen(cmd, shell=False, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     out, err = proc.communicate()
     if err and proc.returncode != 0:
         return proc.returncode, err
     return 0, out.decode().rstrip('\n')
 
 
 def restful_command(cmd):
-    url = "http://240.1.1.1:8080/api/hw/rawcmd"
+    url = "https://240.1.1.1:8080/api/hw/rawcmd"
     data = json.dumps({
         "Command" : cmd
     })