Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-pit] Add PIT(Platform Integration Test) feature, initial commi… #12441

Closed

Conversation

clarklee-guizhao
Copy link
Contributor

…t, with only framework and 2 test cases with 1 supportting platform.

Signed-off-by: Li Hua guizhao.lh@alibaba-inc.com

Why I did it

sonic-pit is originated from S3IP(Simplify Switch System Integration Program) PIT(Platform Integration Test). It's designed to verify switch devices in the process of development, manufacturing and delivering stages. It focus on 2 roles: ODM and user. ODM may use PIT in developing and manufaturing stages, user may use PIT in delivery stage for acceptance test. It aims to provide an verify system for siwtch devices' hardware, drivers and firmware. More information, see HLD: https://github.com/clarklee-guizhao/SONiC/blob/pit/doc/pit/Platform_Integration_Test_high_level_design.md

How I did it

Porting sonic-pit from S3IP-PIT, make the original code clean enough, add PIT source as sonic-pit, add PIT running environment as docker-pit.
The whole PIT system is divided into several PR, this is the first PR with PIT framework and 2 test cases with 1 supporting platform only.

How to verify it

Build docker docker-pit, deploy it onto devices which support sonic-pit, run pit.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Add PIT, whihc include sonic-pit(the PIT system) and docker-pit(the running environment for sonic-pit).

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…t, with only framework and 2 test cases with 1 supportting platform.

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 16 alerts when merging c1ae72b into bc8ee7a - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 4 for Except block handles 'BaseException'
  • 2 for Unused local variable
  • 2 for 'import *' may pollute namespace
  • 1 for Unreachable code
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Variable defined multiple times

@clarklee-guizhao clarklee-guizhao mentioned this pull request Oct 19, 2022
7 tasks
@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2022

This pull request introduces 16 alerts when merging e8ae2a6 into fff6808 - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 4 for Except block handles 'BaseException'
  • 2 for Unused local variable
  • 2 for 'import *' may pollute namespace
  • 1 for Unreachable code
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2022

This pull request introduces 16 alerts when merging ed20ee8 into fff6808 - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 4 for Except block handles 'BaseException'
  • 2 for Unused local variable
  • 2 for 'import *' may pollute namespace
  • 1 for Unreachable code
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Variable defined multiple times

@clarklee-guizhao
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2022

This pull request introduces 16 alerts when merging 8a4b0a4 into fff6808 - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 4 for Except block handles 'BaseException'
  • 2 for Unused local variable
  • 2 for 'import *' may pollute namespace
  • 1 for Unreachable code
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Variable defined multiple times

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 16 alerts when merging a60eaa4 into 81ee948 - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 4 for Except block handles 'BaseException'
  • 2 for Unused local variable
  • 2 for 'import *' may pollute namespace
  • 1 for Unreachable code
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 6 alerts when merging 493d565 into 81ee948 - view on LGTM.com

new alerts:

  • 2 for 'import *' may pollute namespace
  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Unreachable code
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2022

This pull request introduces 6 alerts when merging 5e2f98b into dad3f61 - view on LGTM.com

new alerts:

  • 2 for 'import *' may pollute namespace
  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Unreachable code
  • 1 for Variable defined multiple times

@clarklee-guizhao
Copy link
Contributor Author

close this one, replace with #12514.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants