Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing attribute doesn't affect results of xpath query when using JRuby #1109

Closed
twalpole opened this issue May 19, 2014 · 1 comment
Closed

removing attribute doesn't affect results of xpath query when using JRuby #1109

twalpole opened this issue May 19, 2014 · 1 comment
Labels
platform/jruby

Comments

@twalpole
Copy link
Contributor

Removing an attribute from an element appears to not clear a cache somewhere when using JRuby - behaves correctly when using MRI. Currently causing capybara to fail when used with JRuby and nokogiri 1.6.2.1

doc = Nokogiri::HTML("<html><div selected></div></html>")
elements = doc.xpath('//div[@selected]') 
puts elements.size()   # 1
elements[0].remove_attribute('selected')
puts doc.xpath('//div[@selected]').size()  # 0 with MRI - 1 with JRuby
@twalpole twalpole mentioned this issue May 19, 2014
Closed
@knu knu added the jruby label May 20, 2014
flavorjones added a commit that referenced this issue May 20, 2014
@flavorjones
Added a test case to represent the issue described in #1109.
7808fcd
@flavorjones
Copy link
Member

Thanks so much for reporting this! I've confirmed this issue is present on master and 1.6.2.1.

I've created a branch named "issue-1109-jruby-xpath-cache" with the above code committed as a failing test.

@jvshahid or @yokolet -- either of you want to take a look at addressing this?

twalpole added a commit to teamcapybara/capybara that referenced this issue Jun 2, 2014
@twalpole
Allow jRuby test failure until sparklemotion/nokogiri#1109 is fixed
266b49e
@jvshahid jvshahid mentioned this issue Jul 22, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform/jruby
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flavorjones @knu @twalpole