Fix the index out of bound exception of rank calculation (eclipse-bir…

…t#1797)
speckyspooky · Jul 16, 2024 · 66bebdb · 66bebdb
1 parent af6352c
commit 66bebdb
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/....birt.data.aggregation/src/org/eclipse/birt/data/aggregation/impl/rank/BaseTotalRank.java b/....birt.data.aggregation/src/org/eclipse/birt/data/aggregation/impl/rank/BaseTotalRank.java
@@ -167,28 +167,29 @@ public void finish() throws DataException {
 		 * </code>
 		 *
 		 * @param key
-		 * @return rank
 		 */
 		private void calculateRank(List<Object> sortedList, boolean useDenseRank) {
 
 			int currentRank = 1;
 			int currentDenseRank = 1;
-			Object currentValue = sortedList.get(0);
+			if (sortedList != null && sortedList.size() > 0) {
+				Object currentValue = sortedList.get(0);
 
-			for (int i = 0; i < sortedList.size(); i++) {
-				Object integer = sortedList.get(i);
-				if (!Objects.equals(integer, currentValue)) {
+				for (int i = 0; i < sortedList.size(); i++) {
+					Object integer = sortedList.get(i);
+					if (!Objects.equals(integer, currentValue)) {
+
+						rankMap.put(currentValue, useDenseRank ? currentDenseRank : currentRank);
+						currentValue = integer;
+						currentDenseRank++;
+						currentRank = i + 1;
+					}
 
-					rankMap.put(currentValue, useDenseRank ? currentDenseRank : currentRank);
-					currentValue = integer;
-					currentDenseRank++;
-					currentRank = i + 1;
 				}
 
+				// Handle the last integer in the list
+				rankMap.put(currentValue, useDenseRank ? currentDenseRank : currentRank);
 			}
-
-			// Handle the last integer in the list
-			rankMap.put(currentValue, useDenseRank ? currentDenseRank : currentRank);
 		}
 
 		/*