Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML search: adjust type signatures for custom HTML scoring #12829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HTML search: adjust type signatures for custom HTML scoring #12829

wants to merge 1 commit into from
+2 −2

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Purpose

  • Adjust the type hint for the scoring argument to the IndexBuilder

Detail

  • Currently we have test coverage that provides a scoring value of None -- but the type signature we have on the class doesn't accept that, strictly speaking.
  • Adjust the type signature to accept that single additional value (since we already have test coverage for it).
  • Also: add a str type to the relevant HTML builder config value.

Relates

cc @danieleades

@jayaddison jayaddison mentioned this pull request Aug 30, 2024
Open
@jayaddison jayaddison force-pushed the pr-12816-adjustment/indexbuilder-scorer-typing branch from b6838ca to 23882e9 Compare September 28, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builder:html internals:config internals:typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayaddison