semver 和 publish 的调整 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
完成了。 @afc163 看下有没有问题。 |
| @@ -361,7 +365,7 @@ function abortify(res, options) { | |||
| 406: 'Not acceptable.', | |||
| 415: 'Unsupported media type.', | |||
| 426: 'Upgrade required.', | |||
| 444: 'Force option required.' | |||
| 444: 'Cannot modify pre-existing version.' | |||
There was a problem hiding this comment.
从 npm 上 copy 来的。。两个意思差不多。
|
| var project = new Project({ | ||
| name: req.params.name | ||
| }); | ||
| var version = semver.maxSatisfying(Object.keys(project.packages), req.params.version); |
There was a problem hiding this comment.
这个方法其实已经同时支持了 ~ ^ * 1.x >1.0.0 等各种情况吧？会不会太激进了。
There was a problem hiding this comment.
版本的问题我觉得可以让使用者自己判断，信任一个库才使用他，如果一个库使用了 * 这样的版本范围，则可以选择不用他。
There was a problem hiding this comment.
内部组件(arale, alipay, anima)可以约定下只能用 patch range ~1.1.x。另外，内部工具在构建时候可以判断下范围是否过大，然后给予提示。
|
|
unpublished 的模块展现已加，类似 npm . |
|
安装模块、查询模块、查询模块版本列表时，对于 unpublished 的模块也需要处理吧？ |
|
install, info 等和源相关的操作测试过了，原来的逻辑都兼容的。 |
This reverts commit 9a79839.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加 package 对于 semver 支持
删除
publish -f支持调整
unpublish。不直接删除 package 或 project，只做信息清空，避免变相达到publish -f的操作unpublishPackage 时，添加unpublished信息，删除 tar 包unpublishProject 时，添加unpublished信息，同时对所有的 Package 做unpublish处理publishPackage 时，Project 删除unpublished信息，Package 不允许覆盖unpublished信息的增加 Project unpublish 后的页面展现
相关 issue： spmjs/spm/issues/1001 ， spmjs/spm/issues/1000