fix: avoid timeout for empty Azure transcripts

spokestack · Aug 10, 2021 · f117558 · f117558
1 parent 9bba8f3
commit f117558
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 19 deletions.
diff --git a/src/main/java/io/spokestack/spokestack/microsoft/AzureSpeechRecognizer.java b/src/main/java/io/spokestack/spokestack/microsoft/AzureSpeechRecognizer.java
@@ -231,16 +231,13 @@ public void onEvent(
               SpeechRecognitionEventArgs recognitionArgs) {
             ResultReason reason = recognitionArgs.getResult().getReason();
             String transcript = recognitionArgs.getResult().getText();
-            boolean isFinal = (reason == ResultReason.RecognizedSpeech);
             if (!transcript.equals("")) {
-                if (isFinal) {
+                if (reason == ResultReason.RecognizedSpeech) {
                     dispatchResult(transcript, SpeechContext.Event.RECOGNIZE);
                 } else if (reason == ResultReason.RecognizingSpeech) {
                     dispatchResult(transcript,
                           SpeechContext.Event.PARTIAL_RECOGNIZE);
                 }
-            } else if (isFinal) {
-                this.speechContext.dispatch(SpeechContext.Event.TIMEOUT);
             }
         }
 

diff --git a/src/test/java/io/spokestack/spokestack/microsoft/AzureSpeechRecognizerTest.java b/src/test/java/io/spokestack/spokestack/microsoft/AzureSpeechRecognizerTest.java
@@ -52,7 +52,6 @@ public class AzureSpeechRecognizerTest implements OnSpeechEventListener {
     private SpeechRecognitionEventArgs partialRecognitionEvent;
     private SpeechRecognitionEventArgs emptyTextEvent;
     private SpeechRecognitionEventArgs recognitionEvent;
-    private SpeechRecognitionEventArgs timeoutEvent;
     private SpeechRecognitionCanceledEventArgs canceledEvent;
 
     @Before
@@ -100,13 +99,6 @@ public void setup() {
         doReturn(ResultReason.RecognizedSpeech).when(finalResult).getReason();
         when(recognitionEvent.getResult()).thenReturn(finalResult);
 
-        timeoutEvent = PowerMockito.mock(SpeechRecognitionEventArgs.class);
-        SpeechRecognitionResult timeoutResult =
-              mock(SpeechRecognitionResult.class);
-        doReturn("").when(timeoutResult).getText();
-        doReturn(ResultReason.RecognizedSpeech).when(timeoutResult).getReason();
-        when(timeoutEvent.getResult()).thenReturn(timeoutResult);
-
         canceledEvent = PowerMockito.mock(SpeechRecognitionCanceledEventArgs.class);
         doReturn(CancellationReason.Error).when(canceledEvent).getReason();
         doReturn("unknown error").when(canceledEvent).getErrorDetails();
@@ -185,13 +177,6 @@ public void testListeners() {
         assertEquals(1.0, context.getConfidence());
         assertEquals(SpeechContext.Event.RECOGNIZE, this.event);
 
-        context.reset();
-        new AzureSpeechRecognizer.RecognitionListener(context)
-              .onEvent(mockRecognizer, timeoutEvent);
-        assertEquals("", context.getTranscript());
-        assertEquals(0.0, context.getConfidence());
-        assertEquals(SpeechContext.Event.TIMEOUT, this.event);
-
         this.event = null;
         new AzureSpeechRecognizer.RecognitionListener(context)
               .onEvent(mockRecognizer, emptyTextEvent);