Merge pull request #748 from hazendaz/thorough-cleanup

[cleanup] For allNodes, change def to List<Node>

src/it/basic-1/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/change-xml-filename/verify.groovy

@@ -25,7 +25,7 @@ println '*********************************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/check-bug-file-multi-list/verify.groovy

@@ -28,7 +28,7 @@ println '**********************************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/check-bug-file-multi/verify.groovy

@@ -28,7 +28,7 @@ println '*********************************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/check-bug-file/verify.groovy

@@ -28,7 +28,7 @@ println '*********************************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/check-jvmargs/verify.groovy

@@ -28,7 +28,7 @@ println '*********************************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/check-multi/verify.groovy

@@ -26,7 +26,7 @@ println '*********************************'
 println 'Checking Spotbugs Native XML file'
 println '*********************************'
 
-def allNodes = path.depthFirst().collect { it }
+List<Node> allNodes = path.depthFirst().collect { it }
 int spotbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsErrors}"
 

src/it/check-pluginList-repo/verify.groovy

@@ -28,7 +28,7 @@ println '*********************************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/check/verify.groovy

@@ -31,7 +31,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 
@@ -41,7 +41,7 @@ println '******************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXdoc)
 
-def xNodes = path.depthFirst().collect{ it }
+List<Node> xNodes = path.depthFirst().collect{ it }
 int xdocErrors = xNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${xdocErrors}"
 

src/it/effort-default/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/effort-max/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/effort-min/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/encoding-utf8/verify.groovy

@@ -43,7 +43,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/exclude-modules/verify.groovy

@@ -27,7 +27,7 @@ println 'Checking Spotbugs Native XML file'
 println '*********************************'
 
 
-def allNodes = path.depthFirst().collect { it }
+List<Node> allNodes = path.depthFirst().collect { it }
 int spotbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsErrors}"
 

src/it/exclude-multi-list/verify.groovy

@@ -45,7 +45,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/exclude-multi/verify.groovy

@@ -43,7 +43,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/exclude/verify.groovy

@@ -43,7 +43,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/excludeBugsFile/verify.groovy

@@ -28,7 +28,7 @@ println '******************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXdoc)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${xdocErrors}"
 

src/it/experimental/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/include-multi-list/verify.groovy

@@ -43,7 +43,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/include-multi/verify.groovy

@@ -43,7 +43,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/include/verify.groovy

@@ -43,7 +43,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/maxRank/verify.groovy

@@ -28,7 +28,7 @@ println '******************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXdoc)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${xdocErrors}"
 

src/it/multi-build/verify.groovy

@@ -55,7 +55,7 @@ println '******************'
 
 path = new XmlSlurper().parse(spotbugXdoc)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${xdocErrors}"
 

src/it/multi/verify.groovy

@@ -55,7 +55,7 @@ println '******************'
 
 path = new XmlSlurper().parse(new File(basedir, "modules/${module}/target/spotbugs.xml"))
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${xdocErrors}"
 

src/it/nested/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/no-testsrc/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/omitVisitors/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/onlyAnalyze/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/onlyAnalyzeFileSource/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/pluginList-repo/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/pluginList/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/relaxed/verify.groovy

@@ -48,7 +48,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/site-brazil/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/site-default/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/site-french/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/site-spanish/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/skipEmpty/verify.groovy

@@ -31,7 +31,7 @@ println '*********************************'
 
 GPathResult path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/threaded/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/threshold-experimental/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/threshold-high/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/threshold-low/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"
 

src/it/trace/verify.groovy

@@ -47,7 +47,7 @@ println '*********************************'
 
 path = new XmlSlurper().parse(spotbugXml)
 
-def allNodes = path.depthFirst().collect{ it }
+List<Node> allNodes = path.depthFirst().collect{ it }
 int spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${spotbugsXmlErrors}"