Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep headings are too small #42

Closed
philwebb opened this issue May 6, 2021 · 0 comments
Closed

Deep headings are too small #42

philwebb opened this issue May 6, 2021 · 0 comments
Milestone

Comments

@philwebb
Copy link
Contributor

philwebb commented May 6, 2021

Screen Shot 2021-05-05 at 6 00 52 PM

@philwebb philwebb added this to the 0.0.x milestone May 10, 2021
@philwebb philwebb modified the milestones: 0.0.x, 0.0.1 May 11, 2021
philwebb pushed a commit to philwebb/spring-asciidoctor-backends that referenced this issue Jul 7, 2021
philwebb pushed a commit to philwebb/spring-asciidoctor-backends that referenced this issue Jul 7, 2021
This makes the contract more general and applicable to any GraphQL
request, not necessary coupled to HTTP.

Closes spring-iogh-42
philwebb pushed a commit to philwebb/spring-asciidoctor-backends that referenced this issue Jul 7, 2021
Rename to GraphQLService to make it more clear it is a layer below
the specific transport such as HTTP endpoints.

Add WebGraphQLService sub-interface for query execution in web
environment with a WebInterceptor chain.

See spring-iogh-42
philwebb pushed a commit to philwebb/spring-asciidoctor-backends that referenced this issue Jul 7, 2021
Use getters so the base RequestInput is usable for JSON serialization,
e.g. for the testing support.

Remove WebSocketMessageInput which only had an extra requestId and
add that to WebInput instead.

See spring-iogh-42
philwebb pushed a commit to philwebb/spring-asciidoctor-backends that referenced this issue Jul 7, 2021
Rename "headers" to "responseHeaders" and clarify those work for HTTP
request queries but not for queries over a WebSocket session.

Update getter for response headers to return a read-only wrapper.

Provide only one public constructor without headers.

See spring-iogh-42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant