Bug with recursive partials

[nicoulaj]

When trying to use a recursive partial (ie partial that has itself as a partial), for instance example.mustache:

{{#someCondition}}
    {{>example}}
{{/someCondition}}

Mustache fails with a StackOverflowError in DefaultCode.clone():

java.lang.StackOverflowError
    at com.github.mustachejava.codes.DefaultCode.clone(DefaultCode.java:26)
    at com.github.mustachejava.codes.DefaultCode.clone(DefaultCode.java:30)
    at com.github.mustachejava.codes.DefaultCode.clone(DefaultCode.java:30)
    at com.github.mustachejava.codes.DefaultCode.clone(DefaultCode.java:30)
    ...

[nicoulaj]

Related: mustache/mustache#29

[spullara]

Interesting. There is supposedly a test for this in the spec. Thanks for the report.

[spullara]

I just added something like this as a test and it passes (commit ebf8cbe). Can you send me a pull request with one that doesn't work? If someCondition is always true in your test (or at least a very large number of recursions), it will result in a stack overflow. If it isn't, it should work.

[nicoulaj]

It was indeed trickier than simple recursion.

The template I compile actually extends the one that does recursion. I submitted a test case that shows the StackOverflowError.

Sorry for the incomplete report!

[spullara]

I believe that I have heavy-handidly fixed this issue with this commit:

6d49aca

Your test now passes and the other tests still pass.

[nicoulaj]

I confirm the fix works on my real-world use case with nested partials and recursion.

Thanks for looking into this !