Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openai provider to allow o1 models #62

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

salman1993
Copy link
Collaborator

@salman1993 salman1993 commented Sep 25, 2024

NOTE: we shouldn't merge this since it doesn't work that well

Open AI's o1 models don't allow system msg and tool calling so we workaround it in this PR:

  • the system msg and tool calls are put into the last user msg
  • the tool calls are parsed from the string response msg content

tested this out locally with goose profile:

o1:
  provider: openai
  processor: o1-mini
  accelerator: gpt-4o-mini
  moderator: truncate
  toolkits:
  - name: developer
    requires: {}

Screenshot 2024-09-25 at 3 30 09 PM

^ it works but o1 model doesn't really use the plan tool, so i tried to explicitly ask it but even then it messes it up

Screenshot 2024-09-25 at 3 33 08 PM

Copy link

github-actions bot commented Sep 25, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Update openai provider to allow o1 models". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant