Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add the ability to wrap and unwrap errors with exit codes #21

Merged
merged 1 commit into from
Jun 13, 2023
Merged

feat: Add the ability to wrap and unwrap errors with exit codes #21

merged 1 commit into from
Jun 13, 2023

Conversation

boblail
Copy link
Member

@boblail boblail commented Jun 10, 2023

No description provided.

@boblail boblail force-pushed the lail/wrap-errors branch 2 times, most recently from 1bbb9c8 to cc442d8 Compare June 10, 2023 04:22
@boblail boblail marked this pull request as ready for review June 10, 2023 04:24
@boblail boblail requested a review from quad June 10, 2023 04:33
ryanwalls
ryanwalls approved these changes Jun 12, 2023
View reviewed changes
Copy link

@ryanwalls ryanwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me. I like the single return. Feels lighter weight to use.

@boblail boblail merged commit 142116e into main Jun 13, 2023
@boblail boblail deleted the lail/wrap-errors branch June 13, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanwalls ryanwalls ryanwalls approved these changes

@gpap-squareup gpap-squareup gpap-squareup approved these changes

@quad quad Awaiting requested review from quad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boblail @ryanwalls @gpap-squareup