This repository has been archived by the owner on Aug 26, 2023. It is now read-only.
Fix computeSubwords method #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yammt
commented
Apr 21, 2019
| @@ -155,4 +158,23 @@ public static String readWord(java.io.Reader reader) throws IOException { | |||
| return sb.length() == 0 ? null : sb.toString(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testComputeSubwords() { | |||
| ImmutableMap<String, Set<String>> wordToSubwords = ImmutableMap.of( | |||
There was a problem hiding this comment.
The test cases are generated by https://ideone.com/XR19v4 .
There was a problem hiding this comment.
well, it looks like both versions (c++ and yours java) match.
|
Thanks for PR. Good catch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the link, the Unicode check
(c & 0xC0) == 0x80is only applied if strings are encoded in UTF-8. This PR fixes the character extraction from strings encoded in UTF-16.