Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing links in the CHANGELOG #223

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Add missing links in the CHANGELOG #223

merged 2 commits into from
Jun 6, 2022

Conversation

ericcornelissen
Copy link
Contributor

Add missing links for Pull Requests to the CHANGELOG. I considered adding links for the GitHub users as well, but opted not to as there's no precedence for that.

Also, I wasn't sure whether or not to include this change in the CHANGELOG. It doesn't seem necessary to me, but I'm happy to add it if that's preferred 🙂

Copy link
Owner

@stefanzweifel stefanzweifel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Eric. 👏
I've updated our release-drafter config to link to PRs and authors directly in the future.
(Release notes are automatically put into the CHANGELOG)

I think adding links for all PR authors in the CHANGELOG is not really necessary. Links are also available in the pull requests.

@stefanzweifel stefanzweifel merged commit 789f58e into stefanzweifel:master Jun 6, 2022
@ericcornelissen ericcornelissen deleted the fix-changelog-links branch June 6, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants