feat: use w3 key create instead of ucan-key ed #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olizilla
reviewed
Jan 16, 2024
Comment on lines
+33
to
+45
| Currently the best way to generate a DID is to use the w3up JS CLI: | ||
|
|
||
| <Steps> | ||
| ### Install w3 CLI | ||
|
|
||
| ```sh | ||
| npm install -g @web3-storage/w3cli | ||
| ``` | ||
|
|
||
| ### Generate a DID | ||
|
|
||
| ```sh | ||
| npx ucan-key ed | ||
| w3 key create |
There was a problem hiding this comment.
Maybe leave this as ucan-key as it has fewer dependencies?
Or for the sake of go devs patience, they will still be able to use npx like npx @web3-storage/w3cli key create, as key create doesn't need any existing client state.
There was a problem hiding this comment.
can confirm... npx still works
$ npx @web3-storage/w3cli key create
# did:key:z6Mkuu8gnJEe5uWPtExfwPcC8xvJQr23AmXArmqKXwBYGCEV
MgCZa59TQQ+xTk2ko+Sn+oZZ3ir9bmD6gZ5s09ubqk9I3bO0B5YAVloPr3OhRk9qSEMgV1sHaQFz6mCTeJeYrJkWxL6I=
travis
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the docs to use the new
w3 key createcommand instead ofucan-key ed.Also updates docs for generating a key and delegation and using it to point to relevant docs on the docs site.